Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios-debugging): Close frontend socket unconditionally #3633

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

mbektchiev
Copy link
Contributor

There's no need to keep the frontend socket open after its corresponding
backend socket disconnects. This misleads the Inspector UI that it
is still connected with a backend.

A part of the fix to NativeScript/ios-jsc#927

PR Checklist

What is the current behavior?

When the backend socket disconnects, the frontend socket is closed only if tns debug --no-watch is used.

What is the new behavior?

When the backend socket disconnects, the frontend socket is closed unconditionally.

There's no need to keep the frontend socket open after its corresponding
backend socket disconnects. This misleads the Inspector UI that it
is still connected with a backend.

A part of the fix to NativeScript/ios-jsc#927
@rosen-vladimirov rosen-vladimirov modified the milestones: 4.1.0, 4.1.1 May 29, 2018
@Fatme Fatme merged commit dff5ca4 into release Jun 12, 2018
@Fatme Fatme deleted the bektchiev/ios-debug-close-frontend-socket branch June 12, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants