Don't prepare the project on preview command #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare is needed only to compile typescript and sass files. `preview-sync` hook is added to `nativescript-dev-typescript` and `nativescript-dev-sass` plugins in order to handle the compilation. This way the preview command will be faster as no prepare will be executed.
|
run ci |
DimitarTachev
approved these changes
Nov 19, 2018
| @@ -8,6 +8,16 @@ declare global { | |||
| stopLiveSync(): Promise<void>; | |||
| } | |||
|
|
|||
| interface IPreviewAppFilesService { | |||
| getInitialFilesPayload(data: IPreviewAppLiveSyncData, platform: string, deviceId?: string): FilesPayload; | |||
| getFilesPayload(data: IPreviewAppLiveSyncData, filesData: IPreviewAppFilesData, platform: string, deviceId?: string): FilesPayload; | |||
There was a problem hiding this comment.
data -> liveSyncData
| .filter(file => !_.includes(this.excludedFiles, path.basename(file))) | ||
| .filter(file => !_.includes(this.excludedFileExtensions, path.extname(file))); | ||
|
|
||
| this.$logger.trace(`Transferring ${filesToTransfer.join("\n")}.`); |
There was a problem hiding this comment.
Transferring is not the proper verb for this method
| @@ -78,7 +66,7 @@ export class PreviewAppLiveSyncService implements IPreviewAppLiveSyncService { | |||
| const hookArgs = this.getHookArgs(data, device); | |||
| await this.$hooksService.executeBeforeHooks("preview-sync", { hookArgs }); | |||
| await this.$previewAppPluginsService.comparePluginsOnDevice(data, device); | |||
| const payloads = await this.syncFilesForPlatformSafe(data, device.platform, { isInitialSync: true, useHotModuleReload: data.useHotModuleReload }); | |||
| const payloads = await this.syncInitialFilesForPlatformSafe(data, device.platform); | |||
There was a problem hiding this comment.
syncInitialFilesForPlatformSafe -> getInitialFilesForPlatformSafe
and
initializePreviewForDevice -> getInitialFilesForDevice
|
|
||
| try { | ||
| const payloads = this.$previewAppFilesService.getInitialFilesPayload(data, platform); | ||
| this.$logger.info(`Successfully synced changes for platform ${platform}.`); |
There was a problem hiding this comment.
Successfully synced changes for platform... -> Successfully sent initial files for platform...
| @@ -106,14 +94,45 @@ export class PreviewAppLiveSyncService implements IPreviewAppLiveSyncService { | |||
| return result; | |||
| } | |||
|
|
|||
| private async syncInitialFilesForPlatformSafe(data: IPreviewAppLiveSyncData, platform: string): Promise<FilesPayload> { | |||
| this.$logger.info(`Start syncing changes for platform ${platform}.`); | |||
There was a problem hiding this comment.
Start syncing changes for platform... -> Start sending initial files for platform...
| this.$logger.info(`Successfully synced changes for platform ${platform}.`); | ||
| return payloads; | ||
| } catch (err) { | ||
| this.$logger.warn(`Unable to apply changes for platform ${platform}. Error is: ${err}, ${JSON.stringify(err, null, 2)}.`); |
There was a problem hiding this comment.
${JSON.stringify(err, null, 2)} -> helper
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Project is prepared when
tns previewcommand is executedWhat is the new behavior?
Project is not prepared when
tns previewcommand is executedFixes/Implements/Closes #[Issue Number].
#4141