Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview-api): emit previewAppLiveSyncError when some error is thrown while livesyncing to preview app #4167

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Nov 22, 2018

Usage:

tns.liveSyncService.on("previewAppLiveSyncError", data => {
    console.log("LiveSync error: " + data);
});

PR Checklist

What is the current behavior?

No api exposed to get the errors from livesync operation

What is the new behavior?

Expose an api to get the errors from livesync operation

@Fatme Fatme added this to the 5.0.2 milestone Nov 22, 2018
@Fatme Fatme self-assigned this Nov 22, 2018
@Fatme Fatme added the feature label Nov 22, 2018
@Fatme Fatme merged commit 3bc3814 into release Nov 22, 2018
@Fatme Fatme deleted the fatme/preview-app-livesync-error branch November 22, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants