fix(build-ios): Use BUILD_DIR instead of CONFIGURATION_BUILD_DIR #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `CONFIGURATION_BUILD_DIR` to `xcodebuild` causes the build errors with projects having `nativescript-plugin-firebase` when using Xcode 10's new build system similar to the following: ``` Build system information error: Multiple commands produce '<PbxCp <project-path>/platforms/ios/build/src/core/ext/filters/client_channel/backup_poller.h>': 1) Target 'gRPC-Core' (project 'Pods') has copy command from '<project-path>/platforms/ios/Pods/gRPC-Core/src/core/ext/filters/client_channel/backup_poller.h' to '<project-path>/platforms/ios/build/src/core/ext/filters/client_channel/backup_poller.h' 2) Target 'gRPC-C++' (project 'Pods') has copy command from '<project-path>/platforms/ios/Pods/gRPC-C++/src/core/ext/filters/client_channel/backup_poller.h' to '<project-path>/platforms/ios/build/src/core/ext/filters/client_channel/backup_poller.h' ```
Fatme
approved these changes
Jan 23, 2019
|
run ci |
…pa file found in <some path>` error message
The .ipa file is produced in `platforms/ios/build` folder but the {N} CLI searches it in `platfomrs/ios/build/Debug-iphoneos` folder
|
We need to verify the |
|
run ci |
rosen-vladimirov
approved these changes
Jan 28, 2019
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
CONFIGURATION_BUILD_DIRtoxcodebuildcausesbuild errors with projects having
nativescript-plugin-firebasewhen using Xcode 10's new build system similar to the following:
PR Checklist
related to #4311