Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise debuggerAttached only if app is restarted #4459

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

PR Checklist

What is the current behavior?

In case there's no Developer Disk Image on iOS device, applying a change in code during debug, leads to many crashes and incorrect behavior, as CLI raises debuggerAttached event incorrectly.

What is the new behavior?

You are able to debug in Sidekick without Developer Disk Image

Fixes/Implements/Closes #[Issue Number].

@rosen-vladimirov rosen-vladimirov added this to the 5.3.0 milestone Mar 20, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Mar 20, 2019
@ghost ghost added the new PR label Mar 20, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 20, 2019
@rosen-vladimirov rosen-vladimirov merged commit 871b343 into master Mar 21, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-debug-sidekick branch March 21, 2019 07:41
@ghost ghost removed the new PR label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants