Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vue drawer navigation template to create project command #4652

Merged
merged 1 commit into from
May 28, 2019
Merged

feat: add vue drawer navigation template to create project command #4652

merged 1 commit into from
May 28, 2019

Conversation

elena-p
Copy link
Contributor

@elena-p elena-p commented May 27, 2019

PR Checklist

What is the current behavior?

when vue flavor is selected, an app is created with the vue blank template

What is the new behavior?

when vue flavor is selected, two options are presented - Blank and SideDrawer

Fixes/Implements/Closes #4651.

@elena-p elena-p requested a review from DimitarTachev May 27, 2019 14:07
@cla-bot cla-bot bot added the cla: yes label May 27, 2019
@rosen-vladimirov
Copy link
Contributor

test cli-create

@rosen-vladimirov rosen-vladimirov self-requested a review May 28, 2019 06:21
DimitarTachev
DimitarTachev reviewed May 28, 2019
View reviewed changes
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

rosen-vladimirov
rosen-vladimirov approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@elena-p elena-p merged commit 6343541 into master May 28, 2019
@elena-p elena-p deleted the hristova/add-drawer-navigation-vue-template branch May 28, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

@DimitarTachev DimitarTachev DimitarTachev approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add drawer navigation prompt when vue flavor is selected on tns create
3 participants
@elena-p @rosen-vladimirov @DimitarTachev