fix: multiple errors in Sidekick

[rosen-vladimirov]

fix(cloud, sidekick): don't stop livesync on iOS device without developer disk image when app is built in cloud on windows

The livesync process is stopped when a native change is made in app built in cloud on windows OS. This happens as CLI builds the app and after that tries to restart it. As the platformLiveSyncService.restartApplication is without try/catch, the CLI is not able to start the application due to missing developer disk image mounted on device. After that an error is thrown and the livesync process is stopped. This PR replaces platformLiveSyncService.restartApplication with this.refreshApplication. The this.refreshApplication method has try/catch and shows a warning Unable to start application... when an error is thrown during restart process. On the other side, this method has a check if a naive change occurs, so no additional checks will be executed from the method in order to determine if the application should be refreshed or restarted. (

nativescript-cli/lib/controllers/run-controller.ts

Line 187 in 24b21c4

let shouldRestart = filesChangeEventData && (filesChangeEventData.hasNativeChanges || !filesChangeEventData.hasOnlyHotUpdateFiles);

)

fix(run): remove prepareReadyEvent handler correctly on run

tns run (and using SK) should remove its handler for prepareControllers' prepareReadyEvent handler. However, this does not happend due to two reasons:

• we try to remove the handler from runControllers' event, but this handler is attached to preparController, so it actually remains and causes multiple issues in long living processes, when CLI is used as a library
• the event handler is not cached correctly as we attach its bound version, but cache it without the binding. So you cannot remove it.

This causes issues when running on device in Sidekick, closing the current app, open it again and try to livesync a change - we have many handlers for prepareReadyEvent and this causes multiple livesync operations.

fix(preview): remove prepareReadyEvent handler correctly on preview

tns preview (and using SK) should remove its handler for prepareControllers' prepareReadyEvent handler. However, this does not happend due to two reasons:

• we try to remove the handler from prepareControllers' event, but this handler is attached to preparController, so it actually remains and causes multiple issues in long living processes, when CLI is used as a library
• the event handler is not cached correctly as we attach its bound version, but cache it without the binding. So you cannot remove it.

This causes issues when using preview in Sidekick, closing the current app, open it again and try to livesync a change - we have many handlers for prepareReadyEvent and this causes multiple livesync operations.

fix: remove webpackCompilationComplete handler correctly on prepare

Commands using prepare of project (and using SK) should remove their handlers for webpackCompilerService's webpackCompilationComplete event. This is not happening and whenever we start new prepartion of the project, we attach new handler.

This causes issues when running on device in Sidekick, closing the current app, open it again and try to livesync a change - we have many handlers for prepareReadyEvent and this causes multiple livesync operations.

fix: webpackCompilerService should not cache childProcesses forever

Currently the webpackCompilerService caches the started webpack processes, but it removes them from the cache only when someone calls stopWebpackCompiler method.
This is a major problem as we cache the first instance of the child process and we do not remove it, even when the process dies. For example, when you run just build, we start the webpack process without watch mode, the webpackCompilerService caches the child process, it exits, but the instance remains cached.
Trying to run the application on device does not start new webpack process and different failures occur.

fix: stopPreview does not stop running webpack compilers …

stopPreview method does not stop running webpack compilers, so it is no longer possible to run the same application on device (no matter preview, build or run). This happens in long living processes, like Sidekick.
To fix this, add new parameter to the method - an object containing the projectDir and use it to stop the processes.

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
• Tests for the changes are included.

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

[rosen-vladimirov]

test cli-smoke cli-preview cli-run cli-templates package_version#latest

[rosen-vladimirov]

test cli-smoke cli-preview cli-run cli-templates package_version#latest

[KristianDD]

This is the only change that bothers me a little, but refreshApplication seems to be the only method that can handle missing DDI.