This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix(prepare): clean platforms/.../app/ when running webpack #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test |
sis0k0
force-pushed
the
sis0k0/clean-app-plugin
branch
from
93fb1a3 to
55e7981
Compare
Every time we are running a new build with webpack the platforms/.../app/ dir should be deleted as there may be old assets left. Ex. When the app bundled with snapshot enabled: ``` tns build android --bundle --env.snapshot ``` this produces some assets: ``` platforms/android/.../app/vendor.js platforms/android/.../app/_embedded_script.js // ... ``` Then, if the project is bundled without snapshot: ``` tns build android --bundle ``` the produced assets will override the ones that are already in `platforms/android/.../app`. However, since the build is without snapshot, an `_embedded_script.js` won't be generated to override the one that's left in `platforms/android/.../app` from the previous build. We'll be using `CleanWebpackPlugin` to clean the dist folder. ** Important **: Currently we're running two webpack builds when doing `tns run android|ios` - one on prepare and one when the watcher starts. This means that the dist folder will be cleaned two times. This will be resolved when NativeScript/nativescript-cli#3404 is implemented. fixes #463
sis0k0
force-pushed
the
sis0k0/clean-app-plugin
branch
from
55e7981 to
940a90f
Compare
SvetoslavTsenov
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we are running a new build with webpack the platforms/.../app/ dir should be deleted as there may be old assets
left.
Ex.
When the app bundled with snapshot enabled:
this produces some assets:
Then, if the project is bundled without snapshot:
the produced assets will override the ones that are already in
platforms/android/.../app. However, since the build is withoutsnapshot, an
_embedded_script.jswon't be generated to override the onethat's left in
platforms/android/.../appfrom the previous build.We'll be using
CleanWebpackPluginto clean the dist folder.Important: Currently we're running two webpack builds when doing
tns run android|ios- one on prepare and one when the watcher starts.This means that the dist folder will be cleaned two times. This will be
resolved when
NativeScript/nativescript-cli#3404 is
implemented.
rebased on top of #459
fixes #463