-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements before Qt6 #1020
Improvements before Qt6 #1020
Conversation
Will merge tomorrow if no objections are raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm supportive of these changes and just have a few comments
1783af7
to
8f54ccd
Compare
@YakoYakoYokuYoku please avoid force-pushing without an approval from the reviewer, except for minor stuff (e.g. typo, or 1-line trivial fix), even if you addressed the reviewer's comments. There's no hurry in merging in general. |
- Fixes build breakages caused by PR NatronGitHub#1020
- Fixes build breakages caused by PR NatronGitHub#1020
- Fixes build breakages caused by PR NatronGitHub#1020
- Fixes build breakages caused by PR #1020
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
This adds a pair of corrections in the build system needed for landing Qt6 support, they affect mostly the Python bindings generation and are backwards compatible with Qt5.
Show a few screenshots (if this is a visual change)
N/A.
Have you tested your changes (if applicable)? If so, how?
By building and running Natron.
Futher details of this pull request
This is a stopgap before #1019 can be merged.