Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create GuiApp.pasteNodes() python function #670

Closed
wants to merge 3 commits into from

Conversation

bonalex01dev
Copy link
Contributor

@bonalex01dev bonalex01dev commented Sep 24, 2021

This function paste the nodes in the clipboard.
It will be used to reconnect the pasted nodes to the previously selected node as Nuke does. (good time saver)

Known limitation: the nodes are pasted in a very random place probably related to cursor position.

I copy pasted much of the selectAllNodes code and probably left some useless code

Improvements to be done: ability to paste inside a group

Don't hesitate to criticize: these are my very first line of code in C!

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

[Your answer, explain the motivation for making this change.]

Show a few screenshots (if this is a visual change)

[Your answer, delete this section if it is not a visual change.]

Have you tested your changes (if applicable)? If so, how?

[Your answer]

Futher details of this pull request

[Your answer]

This function paste the nodes in the clipboard.
It will be used to reconnect the pasted nodes to the previously selected node as Nuke does. (good time saver)

Known limitation: the nodes are pasted in a very random place probably related to cursor position.

I copy pasted much of the  selectAllNodes code and probably left some useless code

Improvements to be done: ability to paste inside a group

Don't hesitate to criticize: these are my very first line of code in C!
@rodlie
Copy link
Contributor

rodlie commented Sep 25, 2021

  1. You include several "junk" files from your build
  2. I see several references to "selectAllNodes" in your new function, they should probably be fixed/removed

@devernay
Copy link
Member

devernay commented Oct 5, 2021

replaced by #674

@devernay devernay closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants