Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine/Project: auto save on knob changes #679

Merged
merged 2 commits into from
Oct 11, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Engine/Project.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1667,7 +1667,7 @@ Project::onKnobValueChanged(KnobI* knob,

// auto save on project knobs change
if (shouldAutoSave) {
autoSave();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm, does this resolve the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, reload/close/quit will prompt to save since isSaveUpToDate() is used and that has return _imp->ageSinceLastSave == _imp->lastAutoSave.

_imp->lastAutoSave = QDateTime();
}

return ret;
Expand Down