Qt5 style fixes #915
Closed
Qt5 style fixes #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for Qt5 style regressions.
devernay
reviewed
Sep 5, 2023
| @@ -98,6 +98,7 @@ AboutWindow::AboutWindow(QWidget* parent) | |||
| ///filling tabs now | |||
|
|
|||
| _aboutText = new QTextBrowser(_tabWidget); | |||
| _aboutText->setObjectName( QString::fromUtf8("TextBrowser") ); | |||
There was a problem hiding this comment.
what is the objectname in Qt5? Doesn't it make more sense to use that objectname in the stylesheet as an alternative, rather than cluttering (a tiny bit) the code?
There was a problem hiding this comment.
For some reason QTextBrowser defaults to black text in some widgets, but not all. So adding a objectname makes it easy to style the widgets that needs fixes.
Can of course figure out a better solution, just launched Natron and noticed the issue. Will close and submit a new PR when changed.
There was a problem hiding this comment.
There was a problem hiding this comment.
Agree to avoid code clutter, will find a qss-only fix.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for Qt5 style regressions.
Only tested on Ubuntu with Qt 5.15.3.
Screenshots
Natron 2.5.0 release (Qt4)
Natron RB-2.5 (Qt 5.15.3)
After pull request