Verify plugins are loadable in Windows installer builds and fix missing dependencies #946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Have you tested your changes (if applicable)? If so, how?
Yes. I tested that the new logic properly detects that the plugins were not loadable and causes the build to fail (https://github.com/acolwell/Natron/actions/runs/7935008735). I then added the missing dependencies and verified that the build started passing again (https://github.com/acolwell/Natron/actions/runs/7935721812).
Futher details of this pull request
I'm not exactly sure when libheif took on the new dependencies, but I do know my nightly builds were passing even though the plugins had missing dependencies. This change is intended to make it easier to detect when these new dependencies sneak in and break plugin loading.