Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify plugins are loadable in Windows installer builds and fix missing dependencies #946

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

  • Adds logic to the "Build Installer" GitHub action that verifies that the plugins that are built are actually loadable. This is intended to catch missing dependencies.
  • Added missing libheif dependencies that were preventing the Arena and IO plugins from loading.

Have you tested your changes (if applicable)? If so, how?

Yes. I tested that the new logic properly detects that the plugins were not loadable and causes the build to fail (https://github.com/acolwell/Natron/actions/runs/7935008735). I then added the missing dependencies and verified that the build started passing again (https://github.com/acolwell/Natron/actions/runs/7935721812).

Futher details of this pull request

I'm not exactly sure when libheif took on the new dependencies, but I do know my nightly builds were passing even though the plugins had missing dependencies. This change is intended to make it easier to detect when these new dependencies sneak in and break plugin loading.

@acolwell acolwell requested a review from rodlie February 16, 2024 23:38
@acolwell
Copy link
Collaborator Author

Thank you for the quick review. :)

@acolwell acolwell merged commit 985103e into NatronGitHub:RB-2.5 Feb 17, 2024
3 checks passed
@acolwell acolwell deleted the verify-plugin-loading branch February 17, 2024 02:28
@acolwell acolwell self-assigned this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants