Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #689 #705

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Fixes issue #689 #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
846e6aa
Fixed issue #689
Hugo-ter-Doest Nov 26, 2023
57f0daf
Fixed indentation
Hugo-ter-Doest Nov 26, 2023
f2bfcb1
Trailing whitespace
Hugo-ter-Doest Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/natural/tokenizers/sentence_tokenizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ util.inherits(SentenceTokenizer, Tokenizer)

SentenceTokenizer.prototype.tokenize = function (text) {
// break string up in to sentences based on punctation and quotation marks
let tokens = text.match(/(?<=\s+|^)["'‘“'"[({⟨]?(.*?[.?!…]|[^.?!…]+)(\s[.?!…])*["'’”'"\])}⟩]?(?=\s+|$)/g)
// let tokens = text.match(/(?<=\s+|^)["'‘“'"[({⟨]?.*?[.?!…](\s[.?!…])*["'’”'"\])}⟩]?(?=\s+|$)/g)
let tokens = text.match(/(?<=\s+|^)["'‘“'"[({⟨]?(.*?[.?!…]|.+)(\s[.?!…])*["'’”'"\])}⟩]?(?=\s+|$)/g)

DEBUG && console.log('SentenceTokenizer.tokenize: ' + tokens)

Expand Down
15 changes: 14 additions & 1 deletion spec/sentence_tokenizer_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,31 @@ describe('sentence_tokenizer', function () {
])
})

it('should handle text with the ellipsis symbol … and it should handle last sentence without punctuation (issue #648)', function () {
it('Should handle text with the ellipsis symbol … (issue #648)', function () {
expect(
tokenizer.tokenize('We’re heading for a catastrophic global temperature rise… Fires are blazing from the Amazon to the Arctic.')
).toEqual([
'We’re heading for a catastrophic global temperature rise…',
'Fires are blazing from the Amazon to the Arctic.'
])
})
it('It should handle last sentence without punctuation (issue #648)', function () {
expect(
tokenizer.tokenize('We’re heading for a catastrophic global temperature rise. Fires are blazing from the Amazon to the Arctic')
).toEqual([
'We’re heading for a catastrophic global temperature rise.',
'Fires are blazing from the Amazon to the Arctic'
])
})
it('It should handle the example from issue #689 correctly', function () {
const testInput = `
This is some test content.

We're trying to figure out variations in versions of the package.
`.trim()
expect(tokenizer.tokenize(testInput)).toEqual([
'This is some test content.',
'We\'re trying to figure out variations in versions of the package.'
])
})
})
Loading