Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace prototype inheritance with classes #710

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Replace prototype inheritance with classes #710

merged 1 commit into from
Dec 1, 2023

Conversation

Hugo-ter-Doest
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7058464484

  • 64 of 84 (76.19%) changed or added relevant lines in 21 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 86.512%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/natural/tokenizers/aggressive_tokenizer_it.js 0 1 0.0%
lib/natural/tokenizers/sentence_tokenizer.js 6 7 85.71%
lib/natural/tokenizers/aggressive_tokenizer_no.js 0 2 0.0%
lib/natural/tokenizers/regexp_tokenizer.js 24 26 92.31%
lib/natural/tokenizers/aggressive_tokenizer_pl.js 1 4 25.0%
lib/natural/tokenizers/aggressive_tokenizer_ru.js 1 4 25.0%
lib/natural/tokenizers/aggressive_tokenizer_uk.js 2 5 40.0%
lib/natural/tokenizers/aggressive_tokenizer_fa.js 0 5 0.0%
Totals Coverage Status
Change from base Build 7033445503: -0.1%
Covered Lines: 9589
Relevant Lines: 10693
💛 - Coveralls

@Hugo-ter-Doest Hugo-ter-Doest merged commit e7b8d6b into master Dec 1, 2023
12 checks passed
@Hugo-ter-Doest Hugo-ter-Doest deleted the Replace-prototype-inheritance-with-class-inheritance branch December 1, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hugo-ter-Doest @coveralls