Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the BayesClassifier.load error #724

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

yahyaobeid
Copy link
Contributor

I fixed the error where the BayesClassifier.load() was not returning anything. By adding the static keyword and changing "this.restore" to "BayesClassifier.restore", the load function works properly and the user can classify data with a pre-saved classifier.

Copy link

@baltasaurusrex baltasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wilmerodrigues
Copy link

waiting for this fix

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7809019526

Details

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/natural/classifiers/bayes_classifier.js 0 1 0.0%
Totals Coverage Status
Change from base Build 7138790688: 0.02%
Covered Lines: 9403
Relevant Lines: 10509

💛 - Coveralls

@Hugo-ter-Doest Hugo-ter-Doest merged commit b4b140d into NaturalNode:master Feb 27, 2024
6 checks passed
@Hugo-ter-Doest
Copy link
Collaborator

Thanks! I think it was a leftover from the transition to classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants