Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of sentence tokenizers #751

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Rewrite of sentence tokenizers #751

merged 3 commits into from
Aug 8, 2024

Conversation

Hugo-ter-Doest
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Aug 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10307026450

Details

  • 87 of 88 (98.86%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 87.165%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/natural/tokenizers/sentence_tokenizer.js 86 87 98.85%
Files with Coverage Reduction New Missed Lines %
lib/natural/brill_pos_tagger/lib/Corpus.js 1 72.22%
Totals Coverage Status
Change from base Build 9826305788: 1.3%
Covered Lines: 8928
Relevant Lines: 9896
💛 - Coveralls

@Hugo-ter-Doest Hugo-ter-Doest merged commit fcb696c into master Aug 8, 2024
13 checks passed
@Hugo-ter-Doest Hugo-ter-Doest deleted the #750 branch August 8, 2024 18:14
@Hugo-ter-Doest Hugo-ter-Doest mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hugo-ter-Doest @coveralls