Upgrade visibility from private to protected. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ne-Lexa
approved these changes
Jun 18, 2017
|
I think some changes I made today while testing snuck into this pull request. I did not intend for the changes to the composer.json to get into this. I only made those changes for local testing. I blame a lack of understanding how the pull request works. :-( I thought when I submitted it yesterday that it was done. I didn't realize it would also include changes to my branch made today. We need to revert the changes to package.json. Would you like another pull request for that? |
added 4 commits
June 19, 2017 21:45
|
There we go. Reverted all that stuff that shouldn't have been there. Back to normal now. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow consumers to effectively extend the class and implement custom functionality. For example. I wanted to modify the external attributes of my entries. I found no method available to allow me to do that and decided to simply extend the class and implement a method myself.
Unfortunately, I discovered I couldn't because the visibility of the properties I needed access to was too restrictive. This pull request will address that issue.