Fix annotation errors and align with definitions in NeTEx pt 3 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syversenkr
changed the title
syversenkr
requested review from
seime,
Aurige,
nick-knowles,
skinkie,
ue71603 and
a team
syversenkr
added
the
typo
syversenkr
changed the title
ue71603
approved these changes
Jul 18, 2022
Aurige
reviewed
Jul 18, 2022
| @@ -181,12 +181,12 @@ | |||
| <xsd:choice minOccurs="0"> | |||
| <xsd:element name="ExchangableFromAnyTime" type="EmptyType"> | |||
| <xsd:annotation> | |||
| <xsd:documentation>Special value Can be exhanged from Purchase onwards.</xsd:documentation> | |||
| <xsd:documentation>Special value - Can be exchanged or refunded from any point after purchase.</xsd:documentation> | |||
There was a problem hiding this comment.
I would just say exchanged here (for consistency)
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="ExchangableFromDuration" type="xsd:duration"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Duration to start of period before (negative) or after (positive) the trigger point (i.e. either Start of Validity or First Use ) or that ticket.</xsd:documentation> | ||
| <xsd:documentation>Duration to start of period before (negative) or after (positive) the trigger point (i.e. either Start of Validity or First Use ) after which ticket may be exchanged refunded or resold.</xsd:documentation> |
There was a problem hiding this comment.
I would just say exchanged here (for consistency)
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:choice minOccurs="0"> | ||
| <xsd:element name="ExchangableUntilAnyTime" type="EmptyType"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Can be exchanged anyTime.</xsd:documentation> | ||
| <xsd:documentation>Can be exchanged, refunded or resold up until any point in time after purchase.</xsd:documentation> |
There was a problem hiding this comment.
I would just say exchanged here (for consistency)
| </xsd:annotation> | ||
| </xsd:element> | ||
| <xsd:element name="ExchangableUntilDuration" type="xsd:duration"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Duration to end of period before (negative) or after (positive) the trigger point (i.e. either Start of Validity or First Use ) or that ticket.</xsd:documentation> | ||
| <xsd:documentation>Duration to end of period before (negative) or after (positive) the trigger point (i.e. either Start of Validity or First Use ) after which ticket may be exchanged refunded or resold.</xsd:documentation> |
There was a problem hiding this comment.
I would just say exchanged here (for consistency)
| @@ -242,12 +241,12 @@ | |||
| <xsd:sequence> | |||
| <xsd:element name="HasFee" type="xsd:boolean" minOccurs="0"> | |||
| <xsd:annotation> | |||
| <xsd:documentation>Whether othere is a fee for reselling.</xsd:documentation> | |||
| <xsd:documentation>Whether these is a fee for a refund, exchange or reselling.</xsd:documentation> | |||
There was a problem hiding this comment.
I would just say exchanged here (for consistency)
|
I would favour an harmonised wording: either "exchange" either " resold (ie refunded or exchanged respectively)" but always have the same one |
|
@Aurige |
Aurige
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit only contains cleanup of xsd:documentation
See NeTEx part 3 chapter 7.6.1.3.1.2 Reselling – Model Element and subchapters / underlying element definitions.