Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate enumeration (thanks to David) #509

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Sep 27, 2023

Fix #372 (Directly on master)

btw something is wrong with  xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next
@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Sep 27, 2023
@skinkie skinkie self-assigned this Sep 27, 2023
@skinkie
Copy link
Contributor Author

skinkie commented Sep 27, 2023

@Aurige There is a change in an enum being pantographABove to pantograph, I don't see pantograph ever used in the documentation.

Copy link
Collaborator

@trurlurl trurlurl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge, however, whether the depreciation note wasn't perhaps justified...

Copy link
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping pantographABove (once only of course)

@skinkie
Copy link
Contributor Author

skinkie commented Sep 28, 2023

I would prefer keeping pantographABove (once only of course)

That would certainly be a typo. pantographAbove is something I can live with.

…tEnergy_support.xsd

Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
@skinkie skinkie merged commit 7a1af73 into master Oct 4, 2023
1 check passed
@skinkie skinkie deleted the fix_duplicated_enums branch October 4, 2023 13:31
skinkie added a commit that referenced this pull request Nov 21, 2023
* Update netex_nm_vehicleMeetingPointAssignment_support.xsd (#506)

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>

* Fix improve mode (#507)

* First draft of the clean up of MODE

* Better explanations in VEHICLE MODE
* AccessMode now works TRANSFERs and OTHER LEG (for OJP)
* Some depreciations

* added a mode to Connection

* Update netex_mode_support.xsd

Deprecated not Depreciated ;-)

* Update netex_submode_version.xsd

Deprecated not Depreciated ;-)

* Apply suggestions from code review

* Lint and update documentation tables

* Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

* Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

* Fix passenger information equipment list (#510)

* The connection exists in the documentation, but was not done in the xsd

NeTEx part 1, figure 628

* Fixed according to Christophe's proposal

* Apply suggestions from code review

* Update xsd/netex_part_1/part1_tacticalPlanning/netex_passengerInformationEquipment_version.xsd

* Lint and update documentation tables

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Fix typo's (#511)

* Introduce VAT (#516)

* Introduce VAT number

* Removing duplicate enumeration (thanks to David) (#509)

* Removing duplicate enumeration (thanks to David)

btw something is wrong with  xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next

* Lint and update documentation tables

* Update xsd/netex_framework/netex_reusableComponents/netex_nm_equipmentEnergy_support.xsd

Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* enhancement-TMTC-add ACCEPTED DRIVER PERMITs

Add ACCEPTED DRIVER PERMITS to VEHICEL TYpe

* lint

* revert non-changes

* revert non-changes

* Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

* Apply suggestions from code review

* Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

* Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

* Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

* Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

Co-authored-by: Stefan de Konink <stefan@konink.de>

* Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd

Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Co-authored-by: Nicholas Knowles <nick.knowles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants