Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusual places for JourneyPatternViews #631

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Jan 1, 2024

I cannot think of any argument why one would like to have a JourneyPatternView inside journeyPatternsInFrame. Over either an explicit JourneyPattern, which follows the same content.

<journeyPatterns>
  <JourneyPatternView>
  </JourneyPatternView>
</journeyPatterns>

Neither I do understand why a JourneyPatternView should be part of servicePatternsInFrame.

Proposed to remove in master, since no (poor) example exists for this practise.

@skinkie skinkie added the bug Technical mistake, inconsistency with the documentation, etc. label Jan 1, 2024
@skinkie skinkie self-assigned this Jan 1, 2024
@skinkie skinkie merged commit 1336261 into master Jan 2, 2024
1 check passed
@skinkie skinkie deleted the enh_unchoice branch January 2, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Technical mistake, inconsistency with the documentation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants