Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT connector: bugs fixes, minor improvements, more tests. #158

Merged
merged 10 commits into from
Aug 26, 2022
Merged

Conversation

karim-en
Copy link
Collaborator

@karim-en karim-en commented Aug 26, 2022

  • BridgeTokenFactory: disable indexing of String values in Withdraw event to avoid hashing it.
  • BridgeTokenFactory: add whitelisting getter API.
  • BridgeTokenFactory: improve tests.
  • BridgeTokenFactory: add zero-address verification for ProofConsumerAddress in setProofConsumer().
  • Add more scripts for Ethereum upgrades.

@karim-en karim-en requested a review from sept-en as a code owner August 26, 2022 14:15
@sept-en sept-en added the bug Something isn't working label Aug 26, 2022
@sept-en sept-en changed the title FT connector: fix withdraw event FT connector: bugs fixes, minor improvements, more tests. Aug 26, 2022
Copy link
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sept-en sept-en merged commit d6eacd3 into master Aug 26, 2022
@sept-en sept-en deleted the ft-fix-event branch August 26, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants