Migrate integration tests for bridge-token-factory to workspaces-rs #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sept-en
suggested changes
Aug 31, 2022
sept-en
reviewed
Sep 1, 2022
sept-en
reviewed
Sep 2, 2022
olga24912
force-pushed
the
fix-bridge-token-factory-tests
branch
from
45f5d8f
to
63d8a3f
Compare
sept-en
reviewed
Sep 2, 2022
sept-en
approved these changes
Sep 3, 2022
karim-en
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134
There is a issue with event_serialization tests: in new near-sdk version some checks for AccountId were added. Now AccountId should be more then 2 chars and less then 64 chars and also it can contain only 'a'-'z', '0'..'9', '_', '-', '.' chars
AccountId in res/locked_events.json not suticfied this new rules and should be fix.