Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor audit fixes #245

Merged
merged 2 commits into from
May 30, 2024
Merged

Minor audit fixes #245

merged 2 commits into from
May 30, 2024

Conversation

karim-en
Copy link
Collaborator

@karim-en karim-en commented May 30, 2024 •
edited
Loading

  • Remove unused import Ownable.sol.
  • Remove unused _pausedFlags.
  • Change withdraw argument type from u256 to u128 to avoid potential overflow.
  • Replace OwnableUpgradeable with Ownable2StepUpgradeable

@karim-en karim-en requested review from kiseln and olga24912 May 30, 2024 12:35
@karim-en karim-en changed the title Minor fixes Minor audit fixes May 30, 2024
kiseln
kiseln approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@kiseln kiseln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All minor issues but reasonable

@karim-en karim-en merged commit 7dfa6bf into master May 30, 2024
16 of 19 checks passed
@karim-en karim-en deleted the minor-fixes branch May 30, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiseln kiseln kiseln approved these changes

@olga24912 olga24912 Awaiting requested review from olga24912

Assignees

@kiseln kiseln

@olga24912 olga24912

@karim-en karim-en

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karim-en @kiseln @olga24912