-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create DNS 01 module for Plesk XML API #2562
Conversation
Tested and working with my ISP's plesk XML API, using mydomain.tld and *.mydomain.tld:
Please merge, or advise any other fixes needed - thanks! |
grep -E, sed -E, and [[:space:]] now globally replaced, and correct operation retested:
Can merge now, or any more fixes needed? :) |
(( ... isn't it annoying that basic regex has * but not + ..... ))
Maybe BRE aren't as basic as they sound. But I'm sure `man grep` didn't list the extra syntax of "preceded by backslash" :) So let's use it
@Neilpang - All
Should pass Travis checks. Anything else, or can it be merged now? |
The last issues noted are believed resolved (subject to passing Travis for formatting etc). These were grep -q and sed -r, now all replaced by I've also run this live on my Plesk XML API at my ISP, and it appears to work correctly:
Is anything else needed before merging? |
please create issue and updat wiki. Read this guide carefully: |
Issue created #2577 and wiki updated. Merge now? |
@Neilpang - Any news on this, or anything I need to do? |
Module for Plesk XML API.
Key developer-relevant details: see code header.