security/acme-client: Enable new DNS-01 method "pleskxml" in GUI #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilez
changed the title
fraenki
approved these changes
Nov 7, 2019
|
@stilez Thanks for your contribution! We'll have to wait until your upstream PR is included in an official release of acme.sh. :) |
|
Now merged upstream into dev branch, just waiting for it to appear in a production branch release. |
|
@stilez There's still no official acme.sh release available, but I've merged it anyway. Thanks for your contribution! (This means that it's not working out of the box right now, but the missing acme.sh dnsapi file can still be copied manually.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related upstream commit: (Neilpang's acme.sh PR # 2562), adding a DNS-01 method using the Plesk XML API to
acme.sh. Now merged into acme.sh "dev" branch.This PR contains the code to allow use of that DNS-01 method via the OPNSense GUI.
The DNS-01 method has been accepted, but this PR should continue to be left "on hold" until upstream DNS-01 patch appears in a release