Skip to content

Commit

Permalink
Export mutating functions from Groups interface (#1573)
Browse files Browse the repository at this point in the history
  • Loading branch information
@lgoettgens
lgoettgens authored Jan 26, 2024
1 parent 8f6fe1b commit 0ef1f6a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "AbstractAlgebra"
uuid = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
version = "0.36.5"
version = "0.36.6"

[deps]
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
Expand Down
6 changes: 6 additions & 0 deletions src/AbstractAlgebra.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ import Base: ceil
import Base: checkbounds
import Base: cmp
import Base: conj
import Base: conj!
import Base: convert
import Base: cos
import Base: cosh
Expand Down Expand Up @@ -857,7 +858,9 @@ export coefficients_of_univariate
export collength
export combine_like_terms!
export comm
export comm!
export compose
export conj!
export constant_coefficient
export content
export cycles
Expand All @@ -880,7 +883,9 @@ export direct_sum
export disable_cache!
export discriminant
export div_left
export div_left!
export div_right
export div_right!
export divexact
export divexact_left
export divexact_low
Expand Down Expand Up @@ -1087,6 +1092,7 @@ export nullspace
export num_coeff
export O
export one
export one!
export order
export ordering
export parent_type
Expand Down
10 changes: 0 additions & 10 deletions test/Groups-conformance-tests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,6 @@ function test_GroupElem_interface(g::GEl, h::GEl) where {GEl<:GroupElem}
@test similar(g) isa typeof(g)
end

one!, inv!, mul!, conj!, comm!, div_left!, div_right! = (
AbstractAlgebra.one!,
AbstractAlgebra.inv!,
AbstractAlgebra.mul!,
AbstractAlgebra.conj!,
AbstractAlgebra.comm!,
AbstractAlgebra.div_left!,
AbstractAlgebra.div_right!,
)

@testset "In-place operations" begin
old_g, old_h = deepcopy(g), deepcopy(h)
out = similar(g)
Expand Down

2 comments on commit 0ef1f6a

@thofma
Copy link
Member

@thofma thofma commented on 0ef1f6a Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99638

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.36.6 -m "<description of version>" 0ef1f6a8bf64c2013b235ae10a82369e46970933
git push origin v0.36.6

Please sign in to comment.