Tweak is_symmetric and is_skew_symmetric #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
==========================================
+ Coverage 84.60% 84.63% +0.02%
==========================================
Files 109 109
Lines 29322 29334 +12
==========================================
+ Hits 24809 24826 +17
+ Misses 4513 4508 -5
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lgoettgens
approved these changes
Sep 13, 2023
|
Actually this PR was meant to make both of them take PS: |
- fix their docstrings to say `transpose` instead of `tr` (which is the trace) - align the implementations - ensure they are both applicable to `MatrixElem` with no restrictions - remove redundant `is_symmetric(M::MatElem`) method
fingolfin
force-pushed
the
mh/is_symmetric
branch
from
3d2b43f
to
062ff81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transposeinstead oftr(which is the trace)MatrixElemwith no restrictionsis_symmetric(M::MatElem) method