Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rehaul iteration and indexing #1565

Closed
wants to merge 1 commit into from
Closed

feat: rehaul iteration and indexing #1565

wants to merge 1 commit into from

Conversation

thofma
Copy link
Member

@thofma thofma commented Jan 24, 2024 •
edited
Loading

  • make A[i::Int, js::Array] return a Vector
  • make eachindex(A::MatrixElem) return a rowmajor iterator
  • make iterate(A::MatrixElem) rowmajor

TODO:

  • adjust some of the dummy types
  • tests
  • see how much breaks downstream

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (0ef1f6a) 87.17% compared to head (b44aa38) 85.49%.
Report is 7 commits behind head on master.

❗ Current head b44aa38 differs from pull request most recent head f79bdb4. Consider uploading reports for the commit f79bdb4 to get more accurate results

Files Patch % Lines
src/Matrix.jl 58.62% 24 Missing ⚠️
src/generic/Matrix.jl 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
- Coverage   87.17%   85.49%   -1.69%     
==========================================
  Files         115      115              
  Lines       29565    29621      +56     
==========================================
- Hits        25773    25324     -449     
- Misses       3792     4297     +505

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma force-pushed the th/ittt branch 3 times, most recently from 5a89606 to b44aa38 Compare January 27, 2024 16:20
@thofma
feat: rehaul iteration and indexing
f79bdb4 
- make A[i::Int, js::Array] return a Vector and support views
- make eachindex(A::MatrixElem) return a rowmajor iterator
- delete iterate(A::MatrixElem) (for now)
@thofma thofma mentioned this pull request Jan 29, 2024
Merged
@thofma
Copy link
Member Author

thofma commented Feb 16, 2024

Won't change the iteration and the indexing landed.

@thofma thofma closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thofma