is_finiteorder -> is_finite_order

[joschmitt]

I think is_finiteorder is against the naming conventions? While I'm at it: shouldn't it be has_finite_order?

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.76%. Comparing base (9ab3cbf) to head (44958b6).

Files	Patch %	Lines
src/Groups.jl	33.33%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1639   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files         114      114           
  Lines       29693    29693           
=======================================
  Hits        25763    25763           
  Misses       3930     3930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benlorenz]

I think it would be better for Oscar to make an alias for now and do the deprecation later?

[joschmitt]

I think it would be better for Oscar to make an alias for now and do the deprecation later?

Yes, I wasn't sure whether this would break OSCAR but unfortunately it does.

[fingolfin]

I am for this change, and in fact we discussed it when breaking away for GroupsCore but for various reasons decided to do it later (and then forgot, I guess).

Of course it should be done in a way that maximizes compatibility / minimizes (or better: avoids) breakage.

However, I thought @alias would do that, and in fact OscarCI tests pass, so what is the problem?

[benlorenz]

No problem anymore, when I made my comment it was realized as a deprecation (https://github.com/Nemocas/AbstractAlgebra.jl/compare/55fcbc8a86e68ab49406fc7cc5b2a1d505ea55a0..44958b69cdf32ece70510fd5edac2ed91c897e97) but that is changed now.

[joschmitt]

Too late, but what about the is_finite_order vs has_finite_order?

[lgoettgens]

I am more in favor of is_finite_order, since for the GAP functions in Oscar (of which there are a lot of around groups), there always is an additional has_ and set_. I think this could lead to too much confusion if now has_finite_order does not check if finite_order is set (as the GAP functions would do).

…

On March 22, 2024 9:49:50 AM GMT+01:00, Johannes Schmitt ***@***.***> wrote: Too late, but what about the `is_finite_order` vs `has_finite_order`? -- Reply to this email directly or view it on GitHub: #1639 (comment) You are receiving this because you modified the open/close state. Message ID: ***@***.***>