Add unary add and mul #1640
Merged
Add unary add and mul #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never heard of a unary |
|
Julia Base has both unary + and * for Number, so why not?
…On March 21, 2024 11:52:14 AM GMT+01:00, Johannes Schmitt ***@***.***> wrote:
Never heard of a unary `*` before...
--
Reply to this email directly or view it on GitHub:
#1640 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 114 114
Lines 29694 29696 +2
=======================================
+ Hits 25764 25766 +2
Misses 3930 3930 ☔ View full report in Codecov by Sentry. |
fingolfin
reviewed
Mar 27, 2024
| @@ -73,6 +75,8 @@ end | |||
|
|
|||
| -(x::NCRingElement, y::NCRingElem) = parent(y)(x) - y | |||
|
|
|||
| *(x::NCRingElem) = x | |||
There was a problem hiding this comment.
I don't mind this but it seems really weird
fingolfin
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves oscar-system/Oscar.jl#3538
Cc @joschmitt