Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solve_triu and solve_triu_left for RingElem #1661

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

joschmitt
Copy link
Collaborator

Let's see whether something breaks.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (a49b43f) to head (8e82bab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
+ Coverage   86.92%   86.95%   +0.02%     
==========================================
  Files         115      115              
  Lines       29692    29653      -39     
==========================================
- Hits        25810    25784      -26     
+ Misses       3882     3869      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joschmitt
Copy link
Collaborator Author

What does this Aqua failure persistent tasks tell me? https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/8629741451/job/23654590525?pr=1661
I skimmed https://juliatesting.github.io/Aqua.jl/dev/persistent_tasks/#Persistent-Tasks and I have no idea how this pull request could have affected this.

@thofma
Copy link
Member

thofma commented Apr 10, 2024

@joschmitt
Copy link
Collaborator Author

Looks like nobody is gonna miss these functions.

@thofma thofma merged commit 2da9299 into Nemocas:master Apr 13, 2024
30 of 31 checks passed
@joschmitt joschmitt deleted the js/triu branch April 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants