Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt @show_special to fallback to the dispatch without mime-type... #1663

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

lgoettgens
Copy link
Collaborator

...if not applicable

Furthermore some doc fixes and enhancements.

cc @fingolfin

docs/src/misc.md Outdated Show resolved Hide resolved
Co-authored-by: Johannes Schmitt <jschmitt@posteo.eu>
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (a49b43f) to head (9ab4b6a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   86.92%   86.58%   -0.35%     
==========================================
  Files         115      116       +1     
  Lines       29692    29673      -19     
==========================================
- Hits        25810    25691     -119     
- Misses       3882     3982     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Member

Is the Hecke doctest failure genuine (and perhaps due to this PR "fixing" something?), or a fluke, or something else?!

@lgoettgens
Copy link
Collaborator Author

lgoettgens commented Apr 11, 2024

Is the Hecke doctest failure genuine (and perhaps due to this PR "fixing" something?), or a fluke, or something else?!

Yes, this is "fixing" some printing in Hecke and Oscar. So let's wait with this for the larger printing changes. I'll split off the documentation fixes into a separate PR. I had a mistake in calling applicable here, that should now fix the tests. The printing changes in the failed doctests are something we potentially want to have, but that should be changed downstream in the round of breaking releases.

@lgoettgens
Copy link
Collaborator Author

The one failure is oscar-system/Oscar.jl#3576.

@fingolfin
Copy link
Member

OscarCI#release test failing due to

Starting tests for /home/runner/.julia/packages/Oscar/59YCS/test/Aqua.jl
WARNING: Method definition number_of_generators(AbstractAlgebra.PolyRing{T} where T) in module AbstractAlgebra at /home/runner/work/AbstractAlgebra.jl/AbstractAlgebra.jl/src/Poly.jl:201 overwritten in module Oscar at /home/runner/.julia/packages/Oscar/59YCS/src/Rings/mpoly-affine-algebras.jl:241.
ERROR: Method overwriting is not permitted during Module precompilation. Use `__precompile__(false)` to opt-out of precompilation.

which I believe is not caused by this PR. So merging anyway.

@fingolfin fingolfin merged commit 8fd972a into Nemocas:master Apr 12, 2024
29 of 31 checks passed
@lgoettgens lgoettgens deleted the lg/print-macros branch April 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants