Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all uses of Val #1664

Merged
merged 19 commits into from
Apr 12, 2024
Merged

Fix all uses of Val #1664

merged 19 commits into from
Apr 12, 2024

Conversation

lgoettgens
Copy link
Collaborator

Val{T} is a type and Val(T) its singleton object. This is now the way it is described in the julia docs (https://docs.julialang.org/en/v1/manual/types/#%22Value-types%22).

Everything should be backward compatible due to added deprecations.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 75.34247% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 85.29%. Comparing base (a49b43f) to head (6b2e0b7).
Report is 2 commits behind head on master.

Files Patch % Lines
src/Matrix.jl 69.44% 11 Missing ⚠️
src/AbstractAlgebra.jl 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   86.92%   85.29%   -1.64%     
==========================================
  Files         115      116       +1     
  Lines       29692    29700       +8     
==========================================
- Hits        25810    25332     -478     
- Misses       3882     4368     +486     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Member

Breaks upstream CI:

induction and restriction of characters |    8      8  0.7s
natural characters: Error During Test at /home/runner/.julia/packages/Oscar/59YCS/test/Groups/group_characters.jl:1011
  Test threw exception
  Expression: values(natural_character(hom(G, G, gens(G)))) == [QQAbElem(x, 8) for x = [2o, -2o, z, -(a ^ 3) - a, a ^ 3 + a, z]]
  no common overstructure for the arguments found
  Stacktrace:
    [1] error(s::String)
      @ Base ./error.jl:35
    [2] force_op(::Function, ::Val{true}, ::AbsSimpleNumFieldElem, ::Vararg{AbsSimpleNumFieldElem})
      @ AbstractAlgebra ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/src/AbstractAlgebra.jl:122
    [3] force_op(::Function, ::AbsSimpleNumFieldElem, ::AbsSimpleNumFieldElem)
      @ AbstractAlgebra ~/work/AbstractAlgebra.jl/AbstractAlgebra.jl/src/AbstractAlgebra.jl:128
    [4] ==(a::AbsSimpleNumFieldElem, b::AbsSimpleNumFieldElem)
      @ Nemo ~/.julia/packages/Nemo/9d4V8/src/antic/nf_elem.jl:513
    [5] ==(a::QQAbElem{AbsSimpleNumFieldElem}, b::QQAbElem{AbsSimpleNumFieldElem})
      @ Oscar.AbelianClosure ~/.julia/packages/Oscar/59YCS/src/Rings/AbelianClosure.jl:702
    [6] ==(A::Vector{QQAbElem{AbsSimpleNumFieldElem}}, B::Vector{QQAbElem{AbsSimpleNumFieldElem}})
      @ Base ./abstractarray.jl:2943
    [7] eval_test(evaluated::Expr, quoted::Expr, source::LineNumberNode, negate::Bool)
      @ Test /opt/hostedtoolcache/julia/1.10.2/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:355

@lgoettgens
Copy link
Collaborator Author

lgoettgens commented Apr 12, 2024

The two failures are thofma/Hecke.jl#1428 (restarted) and oscar-system/Oscar.jl#3576.

@fingolfin fingolfin merged commit 79bed80 into Nemocas:master Apr 12, 2024
28 of 31 checks passed
@lgoettgens lgoettgens deleted the lg/Val branch April 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants