Make should_show_banner work with julia 1.11 and nightly

[lgoettgens]

I compared the backtraces of the __init__ call in the cases of using OtherPackage and using Package in 1.11.0-rc1, and the only difference is one single line number. So I added some code to the function that exploits this difference in the most robust way I can think of.

I think we should backport this change to AA 0.41.x afterwards, so that people using Oscar 1.1 with julia 1.11 in the near future (e.g. if julia 1.11 gets released before Oscar 1.2) don't get bloated with banners and instead use this updated code to suppress almost all of them (but one).

cc @benlorenz @lkastner

[codecov]

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.62%. Comparing base (3fc7d25) to head (ef41b00).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/utils.jl	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
- Coverage   87.62%   87.62%   -0.01%     
==========================================
  Files         117      117              
  Lines       30112    30121       +9     
==========================================
+ Hits        26386    26393       +7     
- Misses       3726     3728       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thofma]

@benlorenz are you happy with this?

[benlorenz]

Sorry I somehow missed this while away. I don't really like that we are depending on internal line numbers and struct members but if it works I guess that is fine for now.

Maybe we could add a try/catch block around this to make sure this doesn't cause the packages to fail to load if some internals change in an incompatible way?

[thofma]

I think most of us would prefer a cleaner version, but I think no one has found one so far.

I like the idea of wrapping it around try/catch.

[lgoettgens]

I can do the try/catch thing next week once I am back in office

[lgoettgens]

I now added a try-catch construct around everything, that just returns true (aka is_loaded_directly = true aka banners will be printed) if something gets thrown. For ease of future debugging, the caught exception can be shown by executing ENV["JULIA_DEBUG"] = "AbstractAlgebra" before using SomePackage.

If there are no objections until tomorrow afternoon, I will proceed with merging this, and releasing a 0.41.11 on top of the 0.41.10 release with this backported to get this into Oscar 1.1.

[benlorenz]

thanks!