Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make addmul! fully generic, add docstrings #1801

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

fingolfin
Copy link
Member

Now we can e.g. use addmul! on 3 or 4 ZZMatrix instances and get an efficient result.

Use this to get rid of some now redundant addmul! methods.

Also remove some redundant add! methods and add some sub! methods.

Now we can e.g. use addmul! on 3 or 4 ZZMatrix instances and get an
efficient result.

Use this to get rid of some now redundant `addmul!` methods.

Also remove some redundant `add!` methods and add some `sub!` methods.
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (0f40154) to head (7c30de7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/SparsePoly.jl 0.00% 5 Missing ⚠️
src/generic/MPoly.jl 33.33% 4 Missing ⚠️
src/generic/UnivPoly.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1801   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         119      119           
  Lines       30073    30060   -13     
=======================================
- Hits        26464    26454   -10     
+ Misses       3609     3606    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should wait for downstream tests to confirm (once oscar-system/Oscar.jl#4122 is merged)

@thofma
Copy link
Member

thofma commented Sep 20, 2024

Downstream tests ran and it looks good?

@fingolfin fingolfin merged commit 804ca0d into Nemocas:master Sep 20, 2024
56 of 58 checks passed
@fingolfin fingolfin deleted the mh/addmul branch September 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants