Change return argument order of is_prime_power_with_data
#1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added a commit
to lgoettgens/Hecke.jl
that referenced
this pull request
May 28, 2023
This was referenced May 28, 2023
lgoettgens
force-pushed
the
lg/is_prime_power_with_data
branch
from
eb82d11
to
b5187dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1484 +/- ##
=======================================
Coverage 88.76% 88.77%
=======================================
Files 89 89
Lines 34251 34251
=======================================
+ Hits 30404 30407 +3
+ Misses 3847 3844 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fieker
pushed a commit
to oscar-system/Oscar.jl
that referenced
this pull request
Jul 25, 2023
* various improvements for characters - adjusted the print functions for character tables to the rules from "Details on printing in Oscar" (and adjusted the manual examples and tests) - document the output of the text/plain method for `show` (addresses issue #2482) - fixed the text/latex output in the case that the irrationalities are shown via a legend (and that there are several lines in the legend) - added more documentation and doctests - changed `character_field` for Brauer characters: The field is now a *finite field* in this case. - use the `GAPWrap` approach for more GAP functions * move functions, do not copy them ... * further improvements - fixed a test for `labelled_matrix_formatted` - renamed `group_class_function` to `class_function` - added `natural_character` for matrix groups in positive characteristic and for group homomorphisms - admit `IntegerUnion` for the `characteristic` of character tables, not just `Int` * fixed doctests * adjustments/fixes - adjusted an `is_prime_power_with_data` call (The ordering of return values of `is_prime_power_with_data` has been changed in Nemocas/Nemo.jl/pull/1484.) - adjusted the type of a (perhaps empty) list (This seemed to work at least up to Julia 1.8.5.) - fixed some doctests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves oscar-system/Oscar.jl#2352.
Changes in downstream packages will be handled by thofma/Hecke.jl#1088 and oscar-system/Oscar.jl#2426.
THIS IS BREAKING!!!