Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the documentation of _GF #1500

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

ThomasBreuer
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1500 (b9968b3) into master (74d138e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   88.82%   88.80%   -0.03%     
==========================================
  Files          89       89              
  Lines       34346    34346              
==========================================
- Hits        30508    30500       -8     
- Misses       3838     3846       +8     
Impacted Files Coverage Δ
src/flint/fq_default_extended.jl 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ThomasBreuer
Copy link
Collaborator Author

I do not understand the CI test results:
The test OscarCI / matching: [Oscar#master,Hecke#master,Singular#master] - ubuntu-latest, julia ~1.6.0-0 (pull_request) succeeds, but the test OscarCI / matching: [Oscar#master,Hecke#master,Singular#master] - ubuntu-latest, julia ~1.8.0 fails. However, I think that the differences in the results of the latter test are due to a change in Hecke.jl (thofma/Hecke.jl/pull/1106?) which should affect also the former test.

@thofma
Copy link
Member

thofma commented Jun 27, 2023

1.6 does not do the doctests

@thofma thofma merged commit 81f2284 into Nemocas:master Jun 27, 2023
13 of 15 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_documentation_GF branch June 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants