Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant definition of 'identity' #1526

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

fingolfin
Copy link
Member

Julia already defines Base.identity with the correct semantics

Julia already defines Base.identity with the correct semantics
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1526 (9731230) into master (1d474ab) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   82.83%   82.83%   -0.01%     
==========================================
  Files          95       95              
  Lines       37160    37159       -1     
==========================================
- Hits        30782    30780       -2     
- Misses       6378     6379       +1     
Files Changed Coverage Δ
src/embedding/embedding.jl 99.45% <ø> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma thofma merged commit 1f15e5e into Nemocas:master Aug 22, 2023
14 of 15 checks passed
@fingolfin fingolfin deleted the mh/identity branch August 24, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants