Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZZMatrix modular reduction (issue #2947) #1564

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix ZZMatrix modular reduction (issue #2947) #1564

merged 2 commits into from
Oct 27, 2023

Conversation

JohnAAbbott
Copy link
Contributor

This should correct the issue I reported in #2947

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1564 (99813e7) into master (89b14ca) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
+ Coverage   84.18%   84.20%   +0.02%     
==========================================
  Files          94       94              
  Lines       36614    36634      +20     
==========================================
+ Hits        30824    30849      +25     
+ Misses       5790     5785       -5     
Files Coverage Δ
src/flint/FlintTypes.jl 94.43% <100.00%> (+0.02%) ⬆️
src/flint/fmpz_mod_mat.jl 88.99% <100.00%> (+0.18%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma
Copy link
Member

thofma commented Oct 27, 2023

Looks good. You want to mark this as ready?

@JohnAAbbott JohnAAbbott marked this pull request as ready for review October 27, 2023 12:15
@thofma thofma merged commit 978dd47 into Nemocas:master Oct 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants