Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more special Solve.* methods #1668

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Add more special Solve.* methods #1668

merged 8 commits into from
Feb 10, 2024

Conversation

joschmitt
Copy link
Collaborator

Add some special Solve.kernel methods for types coming from flint or non-domain rings. All of this is more or less taken from HeckeMiscMatrix.jl.
I add tests in the next days; I just wanted to push this to ask about some things before I forget them.

`hnf(lazy_transpose(A))` would not use the correct HNF method, so we
have to really transpose in this case
@joschmitt joschmitt marked this pull request as draft February 8, 2024 18:19
src/flint/fmpz_mod_mat.jl Outdated Show resolved Hide resolved
src/flint/fmpz_mod_mat.jl Outdated Show resolved Hide resolved
src/flint/nmod_mat.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (644d981) 84.36% compared to head (ebee84a) 84.41%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   84.36%   84.41%   +0.04%     
==========================================
  Files          93       93              
  Lines       37159    37234      +75     
==========================================
+ Hits        31350    31431      +81     
+ Misses       5809     5803       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joschmitt joschmitt marked this pull request as ready for review February 9, 2024 17:00
@joschmitt
Copy link
Collaborator Author

joschmitt commented Feb 9, 2024

Good to go, but needs Nemocas/AbstractAlgebra.jl#1598 .
(I will add more nullspaces calling C code for the finite field types at a later point. The first objective is to get the new interface into OSCAR.)

TODO (so I still know this on Monday):

  • bump AA once Further solving related adjustments AbstractAlgebra.jl#1598 is merged and registered
  • maybe change the default side of eigenspace and eigenspaces too for constistency. Would make this PR a (tiny) breaking change, but then we would have (a chance to have) all the breaking changes at once in OSCAR.

@thofma thofma merged commit ae0c3b1 into Nemocas:master Feb 10, 2024
13 of 15 checks passed
@joschmitt joschmitt deleted the js/solve branch February 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants