Add fit!
for all MPolyRingElem
subtypes
#1823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MPoly interface (https://nemocas.github.io/AbstractAlgebra.jl/dev/mpoly_interface/#Unsafe-functions) states that these must exist. When trying to run the UnivPoly testsuite from AA with Nemo rings to verify the correctness of my changes for Nemocas/AbstractAlgebra.jl#1746, there were a lot of MethodErrors due to these missing.
One could potentially look in FLINT if there are corresponding functions there that can be hooked up, but that is not needed currently.