-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up HeckeMiscInteger.jl
#1848
Conversation
bfbac37
to
82042ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
+ Coverage 86.19% 87.06% +0.86%
==========================================
Files 98 98
Lines 36210 40661 +4451
==========================================
+ Hits 31212 35400 +4188
- Misses 4998 5261 +263 ☔ View full report in Codecov by Sentry. |
71ae202
to
8f87b0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
||
^(a::T, n::IntegerUnion) where {T<:RingElem} = _generic_power(a, n) | ||
|
||
function _generic_power(a, n::IntegerUnion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really specific to ZZRingElem
. I wonder if we should have a src/generic.jl
file or perhaps src/generic
dir in which we move such "generic" code (I think we have more examples in this vein).
Anyway, also OK by me to move it here for now. Just food for thought (since you've been touching many of these files, you probably have a better feeling than me whether this idea has merit or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some functions where it is not really clear, where they should go. In the end, I wouldn't know where I would search for a generic powering function, so I would need git grep
anyway...
The behaviour of
mod_sym
is still open for debate.