Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize mat_entry_ptr methods #1871

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Optimize mat_entry_ptr methods #1871

merged 2 commits into from
Sep 30, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.31%. Comparing base (8b486cc) to head (fe7adac).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/nmod_mat.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1871      +/-   ##
==========================================
- Coverage   87.33%   87.31%   -0.03%     
==========================================
  Files          97       97              
  Lines       35858    35832      -26     
==========================================
- Hits        31316    31285      -31     
- Misses       4542     4547       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lgoettgens
lgoettgens approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, I don't really understand all of the formulas, but trust you with this

fingolfin
fingolfin commented Sep 30, 2024
View reviewed changes
src/flint/fmpq_mat.jl Outdated Show resolved Hide resolved
fingolfin
fingolfin commented Sep 30, 2024
View reviewed changes
src/flint/fmpz_mat.jl Outdated Show resolved Hide resolved
fingolfin
fingolfin commented Sep 30, 2024
View reviewed changes
src/flint/fmpz_mod_mat.jl Outdated Show resolved Hide resolved
fingolfin
fingolfin commented Sep 30, 2024
View reviewed changes
src/flint/gfp_fmpz_mat.jl Outdated Show resolved Hide resolved
@lgoettgens
Copy link
Collaborator

These explanations really help! Thanks!

@fingolfin fingolfin mentioned this pull request Sep 30, 2024
Open
thofma
thofma approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@thofma thofma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works it works

@lgoettgens lgoettgens enabled auto-merge (squash) September 30, 2024 18:54
@lgoettgens lgoettgens merged commit fbef9d1 into master Sep 30, 2024
23 of 25 checks passed
@lgoettgens lgoettgens deleted the mh/mat_entry_ptr branch September 30, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thofma thofma thofma approved these changes

@lgoettgens lgoettgens lgoettgens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @lgoettgens @thofma