Handle incompatible/dependant for options
#1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of the `incompatible` and `dependant` concepts are only implemented for switches, not options. However, options can be incompatible or dependent on each other and switches as well. Handle both concepts between all options and switches. Use the existing `toggle_switch`/`set_option` to do the disabling so that any recursive dependencies are resolved as well.
|
Fantastic - no notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the
incompatibleanddependantconcepts are only implemented for switches, not options. However, options can be incompatible or dependent on each other and switches as well.Handle both concepts between all options and switches. Use the existing
toggle_switch/set_optionto do the disabling so that any recursive dependencies are resolved as well.