Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up annotations on APIs that can be made public and document the ability to create custom popups #1546

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Clean up annotations on APIs that can be made public and document the ability to create custom popups #1546

merged 6 commits into from
Nov 7, 2024

Commits on Nov 7, 2024

  1. Remove duplicated PopupData definition 

    This is a subset of the `PopupData` defined in `popup/init.lua` and is
throwing LSP warnings.
    @zivarah @CKolkey
    zivarah authored and CKolkey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4f84117 View commit details
    Browse the repository at this point in the history

  2. Fix config entry type

    @zivarah @CKolkey
    zivarah authored and CKolkey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5781297 View commit details
    Browse the repository at this point in the history

  3. Clean up some of the builder annotations

    @zivarah @CKolkey
    zivarah authored and CKolkey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ab40701 View commit details
    Browse the repository at this point in the history

  4. Flesh out some missing builder annotations

    @zivarah @CKolkey
    zivarah authored and CKolkey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    563b4d6 View commit details
    Browse the repository at this point in the history

  5. Clean up trailing whitespaces in docs

    @zivarah @CKolkey
    zivarah authored and CKolkey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    bee092a View commit details
    Browse the repository at this point in the history

  6. Mention the possibility of custom popups in the docs

    @zivarah @CKolkey
    zivarah authored and CKolkey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b917302 View commit details
    Browse the repository at this point in the history