Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always reset status when opening neogit #932

Closed
wants to merge 2 commits into from
Closed

Always reset status when opening neogit #932

wants to merge 2 commits into from

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Nov 9, 2023

Fixes #931

ten3roberts
ten3roberts approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ten3roberts ten3roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, simple and easy solution.

The dreaded enemy of all programmers: cache invalidation

@ten3roberts
Copy link
Member

As for the tests, it is likely they fail as they assume neogit opens and has the correct state immediately, but now such happens in the next event loop tick.

There may be an easy "wait for everything to open" for those tests

@ten3roberts ten3roberts mentioned this pull request Nov 14, 2023
Closed
@smatting
Copy link
Contributor Author

The dreaded enemy of all programmers: cache invalidation

Maybe the cleanest way would be not to cache this at all. Any objections against trying this?

@CKolkey
Copy link
Member

CKolkey commented Nov 15, 2023

I'm up to try, sure :)

@smatting
Copy link
Contributor Author

Closing this in favor of #944

@smatting smatting closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ten3roberts ten3roberts ten3roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing CWD breaks action on hunks
3 participants
@smatting @ten3roberts @CKolkey