Allow building of coinbase transactions with invalid transaction proofs #242
Labels
Comments
aszepieniec
added a commit
that referenced
this issue
Dec 6, 2024
Allow caller to specify proof quality of coinbase transaction. This change has the benefit of allowing tests that do need coinbase transactions but not necessarily with valid proofs. This closes #242. Co-authored-by: Thorkil Schmidiger <thor@neptune.cash>
Sword-Smith
added a commit
that referenced
this issue
Dec 6, 2024
Allow caller to specify proof quality of coinbase transaction. This change has the benefit of allowing tests that do need coinbase transactions but not necessarily with valid proofs. This closes #242. Co-authored-by: Thorkil Schmidiger <thor@neptune.cash>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since we have to build valid
SingleProofs everytime we build a transaction that goes into a block, tests of this logic are either inflexible, as proof have to be stored on a proof server, or they're very slow.The function
mine_block_to_wallet_invalid_block_proofshould not just make invalid block proofs but also invalid transaction proofs, for both merged transactions and for coinbase transactions.The text was updated successfully, but these errors were encountered: