feat: support for tokio-console #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --tokio-console boolean cli arg to neptune-core. When this flag is present, logging is configured to emit tokio tracing information and send it to localhost:6669 for processing by tokio-console. This requires building tokio with the `tokio_unstable` build flag. This is specified in the new `.cargo/config.toml` see: https://github.com/tokio-rs/console
dan-da
force-pushed
the
tokio-console
branch
from
e108486 to
21a559b
Compare
Sword-Smith
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
This looks exciting :)
Hope we can get rid of unstable down the line though. I hope unstable will work on Windows. If not, then maybe one could handle this with a environment variable that is only set on Unix/Linux.
cf. https://docs.rs/tokio/latest/tokio/#unstable-features
|
I have my doubts that it will move out of unstable any time soon. I'm viewing this as a temporary thing and maybe we disable or remove it or improve build configurability before mainnet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--tokio-consoleboolean cli arg to neptune-core.When this flag is present, logging is configured to emit tokio tracing information and send it to localhost:6669 for processing by tokio-console.
This requires building tokio with the
tokio_unstablebuild flag. This is specified in the new.cargo/config.tomlsee: https://github.com/tokio-rs/console
Here's a screenshot of the
resourcesview: