Skip to content

Commit

Permalink
Merge branch 'main' into fix/issues
Browse files Browse the repository at this point in the history
* main:
  fix: 修复solid的onShow,onHide不生效的bug (#16569)
  fix(taro-cli): 修正tsconfig-paths-webpack-plugin插件的导入条件
  fix(taro-cli): 使TS条件下生成的模板,import与export间保持一行空隙,以避免ESLint报错
  • Loading branch information
koppthe committed Oct 15, 2024
2 parents 4fac460 + 5148dd6 commit 408de12
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions packages/taro-cli/templates/default/config/dev.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#if typescript }}import type { UserConfigExport } from "@tarojs/cli";
{{/if}}
{{#if typescript }}import type { UserConfigExport } from "@tarojs/cli"{{/if}}

export default {
{{#if (eq compiler "Webpack5") }} logger: {
quiet: false,
Expand Down
4 changes: 2 additions & 2 deletions packages/taro-cli/templates/default/config/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { defineConfig{{#if typescript }}, type UserConfigExport{{/if}} } from '@tarojs/cli'
{{#if typescript }}import TsconfigPathsPlugin from 'tsconfig-paths-webpack-plugin'{{/if}}
{{#if typescript }}{{#unless (eq compiler "Vite")}}import TsconfigPathsPlugin from 'tsconfig-paths-webpack-plugin'{{/unless}}{{/if}}
import devConfig from './dev'
import prodConfig from './prod'
Expand Down Expand Up @@ -46,7 +46,7 @@ export default defineConfig{{#if typescript }}<'{{ to_lower_case compiler }}'>{{
generateScopedName: '[name]__[local]___[hash:base64:5]'
}
}
}{{#if typescript }},{{#unless (eq compiler "Vite")}}
},{{#if typescript }}{{#unless (eq compiler "Vite")}}
webpackChain(chain) {
chain.resolve.plugin('tsconfig-paths').use(TsconfigPathsPlugin)
}{{/unless}}{{/if}}
Expand Down
4 changes: 2 additions & 2 deletions packages/taro-cli/templates/default/config/prod.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#if typescript }}import type { UserConfigExport } from "@tarojs/cli";
{{/if}}
{{#if typescript }}import type { UserConfigExport } from "@tarojs/cli"{{/if}}

export default {
mini: {},
h5: {
Expand Down
1 change: 0 additions & 1 deletion packages/taro-framework-solid/src/runtime/connect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ type SolidComponent = (props?: any) => TaroNode;

export function setReconciler () {
hooks.tap('getLifecycle', function (instance, lifecycle: string) {
lifecycle = lifecycle.replace(/^on(Show|Hide)$/, 'componentDid$1')
return instance[lifecycle]
})

Expand Down

0 comments on commit 408de12

Please sign in to comment.